Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: ACNA-1240 - Added ability to accept Dev Terms of Service #509

Merged
merged 8 commits into from
Mar 14, 2022
Merged

feat: ACNA-1240 - Added ability to accept Dev Terms of Service #509

merged 8 commits into from
Mar 14, 2022

Conversation

florind-ens
Copy link
Contributor

@florind-ens florind-ens commented Jan 26, 2022 •
edited by shazron
Loading

Description

This PR requires:

Related Issue

Closes #446

Motivation and Context

How Has This Been Tested?

unit tests.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • [] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@florind-ens florind-ens self-assigned this Jan 26, 2022
@codecov
Copy link

codecov bot commented Jan 26, 2022 •
edited
Loading

Codecov Report

Merging #509 (711f669) into master (cc6230a) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #509   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           50        50           
  Lines         2571      2584   +13     
  Branches       460       464    +4     
=========================================
+ Hits          2571      2584   +13
Impacted Files Coverage Δ
src/commands/app/init.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cc6230a...711f669. Read the comment docs.

shazron
shazron requested changes Mar 7, 2022
View reviewed changes
src/commands/app/init.js Outdated Show resolved Hide resolved
src/commands/app/init.js Outdated Show resolved Hide resolved
src/commands/app/init.js Outdated Show resolved Hide resolved
@shazron shazron changed the title feat. ACNA-1240 Added ability to accept dev terms. feat: ACNA-1240 - Added ability to accept Dev Terms of Service Mar 7, 2022
@florind-ens florind-ens merged commit ed46cbe into master Mar 14, 2022
@shazron shazron deleted the story/ACNA-1240-accept-dev-terms branch August 25, 2022 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shazron shazron shazron approved these changes

@purplecabbage purplecabbage Awaiting requested review from purplecabbage

@Himavanth Himavanth Awaiting requested review from Himavanth

@sandeep-paliwal sandeep-paliwal Awaiting requested review from sandeep-paliwal

Assignees

@florind-ens florind-ens

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add ability to accept Developer Terms in the Console API
3 participants
@florind-ens @shazron @purplecabbage